Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Sitegen Capability Check #412

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Jan 15, 2024

Screenshot 2024-01-17 at 12 35 47 PM

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Jan 15, 2024
@officiallygod officiallygod added this to the AI Onboarding v1.0 milestone Jan 15, 2024
@officiallygod officiallygod self-assigned this Jan 15, 2024
@officiallygod officiallygod changed the title Add Frontend! AI Sitegen Capability Check Jan 15, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Jan 15, 2024
Comment on lines 10 to 11
const AI_FLOW = 'ai';
const ONBOARDING_FLOW = 'onboarding';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds Good, Let me do that.

@@ -53,9 +55,9 @@ const StartOptions = ( { questionnaire, oldFlow, options } ) => {
};
const selectFlow = ( flow ) => {
switch ( flow ) {
case 'onboarding':
case ONBOARDING_FLOW:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maintain consistency by changing the terms onboarding, ai and sitegen to align with what we already have, which are, wp-setup, ecommerce, and sitegen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doubtful as of ONBOARDING_FLOW covers both wp-setup as well as ecommerce, lemme look and make it aligned

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Pink X button on the Logo Step.

@officiallygod officiallygod added WIP PR is a Work in Progress and not ready for review. and removed Code Review The PR is in Code Review labels Jan 17, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Jan 17, 2024
@arunshenoy99 arunshenoy99 merged commit cbe2366 into enhance/ai-onboarding Jan 17, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the sitegen-hiive-capability-flag branch January 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants